mirror of
https://github.com/spring-projects/spring-boot.git
synced 2024-08-29 03:06:45 +08:00
Polish
See gh-25617
This commit is contained in:
parent
11649bc1f0
commit
09f4d4b9bf
@ -62,7 +62,7 @@ public class ToolchainPlugin implements Plugin<Project> {
|
||||
}
|
||||
}
|
||||
|
||||
public boolean isJavaVersionSupported(ToolchainExtension toolchain, JavaLanguageVersion toolchainVersion) {
|
||||
private boolean isJavaVersionSupported(ToolchainExtension toolchain, JavaLanguageVersion toolchainVersion) {
|
||||
return toolchain.getMaximumCompatibleJavaVersion().map((version) -> version.canCompileOrRun(toolchainVersion))
|
||||
.getOrElse(true);
|
||||
}
|
||||
|
@ -27,9 +27,7 @@ import org.springframework.boot.actuate.autoconfigure.endpoint.web.WebEndpointAu
|
||||
import org.springframework.boot.actuate.autoconfigure.web.jersey.JerseySameManagementContextConfiguration;
|
||||
import org.springframework.boot.autoconfigure.AutoConfigurations;
|
||||
import org.springframework.boot.autoconfigure.jersey.JerseyAutoConfiguration;
|
||||
import org.springframework.boot.autoconfigure.logging.ConditionEvaluationReportLoggingListener;
|
||||
import org.springframework.boot.autoconfigure.web.servlet.ServletWebServerFactoryAutoConfiguration;
|
||||
import org.springframework.boot.logging.LogLevel;
|
||||
import org.springframework.boot.test.context.FilteredClassLoader;
|
||||
import org.springframework.boot.test.context.runner.WebApplicationContextRunner;
|
||||
import org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext;
|
||||
@ -55,7 +53,6 @@ class JerseyWebEndpointIntegrationTests {
|
||||
JerseyWebEndpointManagementContextConfiguration.class))
|
||||
.withUserConfiguration(ResourceConfigConfiguration.class)
|
||||
.withClassLoader(new FilteredClassLoader(DispatcherServlet.class))
|
||||
.withInitializer(new ConditionEvaluationReportLoggingListener(LogLevel.INFO))
|
||||
.withPropertyValues("spring.jersey.type=filter", "server.port=0").run((context) -> {
|
||||
assertThat(context).hasNotFailed();
|
||||
Set<Resource> resources = context.getBean(ResourceConfig.class).getResources();
|
||||
|
@ -19,8 +19,6 @@ package org.springframework.boot.autoconfigure.rsocket;
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import org.springframework.boot.autoconfigure.AutoConfigurations;
|
||||
import org.springframework.boot.autoconfigure.logging.ConditionEvaluationReportLoggingListener;
|
||||
import org.springframework.boot.logging.LogLevel;
|
||||
import org.springframework.boot.rsocket.context.RSocketPortInfoApplicationContextInitializer;
|
||||
import org.springframework.boot.rsocket.context.RSocketServerBootstrap;
|
||||
import org.springframework.boot.rsocket.server.RSocketServerCustomizer;
|
||||
@ -148,7 +146,6 @@ class RSocketServerAutoConfigurationTests {
|
||||
@Test
|
||||
void whenSpringWebIsNotPresentThenEmbeddedServerConfigurationBacksOff() {
|
||||
contextRunner().withClassLoader(new FilteredClassLoader(ReactorResourceFactory.class))
|
||||
.withInitializer(new ConditionEvaluationReportLoggingListener(LogLevel.INFO))
|
||||
.withPropertyValues("spring.rsocket.server.port=0")
|
||||
.run((context) -> assertThat(context).doesNotHaveBean(RSocketServerFactory.class));
|
||||
}
|
||||
|
@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2019 the original author or authors.
|
||||
* Copyright 2012-2021 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@ -64,10 +64,8 @@ class ConfigurationMetadataRepositoryJsonBuilderTests extends AbstractConfigurat
|
||||
|
||||
@Test
|
||||
void severalRepositoriesNoConflict() throws IOException {
|
||||
try (InputStream foo = getInputStreamFor("foo")) {
|
||||
try (InputStream bar = getInputStreamFor("bar")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, bar)
|
||||
.build();
|
||||
try (InputStream foo = getInputStreamFor("foo"); InputStream bar = getInputStreamFor("bar")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, bar).build();
|
||||
validateFoo(repo);
|
||||
validateBar(repo);
|
||||
assertThat(repo.getAllGroups()).hasSize(2);
|
||||
@ -76,14 +74,11 @@ class ConfigurationMetadataRepositoryJsonBuilderTests extends AbstractConfigurat
|
||||
assertThat(repo.getAllProperties()).hasSize(6);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void repositoryWithRoot() throws IOException {
|
||||
try (InputStream foo = getInputStreamFor("foo")) {
|
||||
try (InputStream root = getInputStreamFor("root")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, root)
|
||||
.build();
|
||||
try (InputStream foo = getInputStreamFor("foo"); InputStream root = getInputStreamFor("root")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, root).build();
|
||||
validateFoo(repo);
|
||||
assertThat(repo.getAllGroups()).hasSize(2);
|
||||
|
||||
@ -92,16 +87,13 @@ class ConfigurationMetadataRepositoryJsonBuilderTests extends AbstractConfigurat
|
||||
assertThat(repo.getAllProperties()).hasSize(5);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void severalRepositoriesIdenticalGroups() throws IOException {
|
||||
try (InputStream foo = getInputStreamFor("foo")) {
|
||||
try (InputStream foo2 = getInputStreamFor("foo2")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, foo2)
|
||||
.build();
|
||||
Iterable<String> allKeys = Arrays.asList("spring.foo.name", "spring.foo.description",
|
||||
"spring.foo.counter", "spring.foo.enabled", "spring.foo.type");
|
||||
try (InputStream foo = getInputStreamFor("foo"); InputStream foo2 = getInputStreamFor("foo2")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, foo2).build();
|
||||
Iterable<String> allKeys = Arrays.asList("spring.foo.name", "spring.foo.description", "spring.foo.counter",
|
||||
"spring.foo.enabled", "spring.foo.type");
|
||||
assertThat(repo.getAllProperties()).containsOnlyKeys(allKeys);
|
||||
assertThat(repo.getAllGroups()).containsOnlyKeys("spring.foo");
|
||||
ConfigurationMetadataGroup group = repo.getAllGroups().get("spring.foo");
|
||||
@ -110,49 +102,41 @@ class ConfigurationMetadataRepositoryJsonBuilderTests extends AbstractConfigurat
|
||||
"org.springframework.boot.FooProperties");
|
||||
assertThat(group.getSources().get("org.acme.Foo").getProperties()).containsOnlyKeys("spring.foo.name",
|
||||
"spring.foo.description");
|
||||
assertThat(group.getSources().get("org.acme.Foo2").getProperties())
|
||||
.containsOnlyKeys("spring.foo.enabled", "spring.foo.type");
|
||||
assertThat(group.getSources().get("org.acme.Foo2").getProperties()).containsOnlyKeys("spring.foo.enabled",
|
||||
"spring.foo.type");
|
||||
assertThat(group.getSources().get("org.springframework.boot.FooProperties").getProperties())
|
||||
.containsOnlyKeys("spring.foo.name", "spring.foo.counter");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void severalRepositoriesIdenticalGroupsWithSameType() throws IOException {
|
||||
try (InputStream foo = getInputStreamFor("foo")) {
|
||||
try (InputStream foo3 = getInputStreamFor("foo3")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, foo3)
|
||||
.build();
|
||||
Iterable<String> allKeys = Arrays.asList("spring.foo.name", "spring.foo.description",
|
||||
"spring.foo.counter", "spring.foo.enabled", "spring.foo.type");
|
||||
try (InputStream foo = getInputStreamFor("foo"); InputStream foo3 = getInputStreamFor("foo3")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, foo3).build();
|
||||
Iterable<String> allKeys = Arrays.asList("spring.foo.name", "spring.foo.description", "spring.foo.counter",
|
||||
"spring.foo.enabled", "spring.foo.type");
|
||||
assertThat(repo.getAllProperties()).containsOnlyKeys(allKeys);
|
||||
assertThat(repo.getAllGroups()).containsOnlyKeys("spring.foo");
|
||||
ConfigurationMetadataGroup group = repo.getAllGroups().get("spring.foo");
|
||||
assertThat(group.getProperties()).containsOnlyKeys(allKeys);
|
||||
assertThat(group.getSources()).containsOnlyKeys("org.acme.Foo",
|
||||
"org.springframework.boot.FooProperties");
|
||||
assertThat(group.getSources()).containsOnlyKeys("org.acme.Foo", "org.springframework.boot.FooProperties");
|
||||
assertThat(group.getSources().get("org.acme.Foo").getProperties()).containsOnlyKeys("spring.foo.name",
|
||||
"spring.foo.description", "spring.foo.enabled", "spring.foo.type");
|
||||
assertThat(group.getSources().get("org.springframework.boot.FooProperties").getProperties())
|
||||
.containsOnlyKeys("spring.foo.name", "spring.foo.counter");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void severalRepositoriesIdenticalGroupsWithSameTypeDoesNotOverrideSource() throws IOException {
|
||||
try (InputStream foo = getInputStreamFor("foo")) {
|
||||
try (InputStream foo3 = getInputStreamFor("foo3")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, foo3)
|
||||
.build();
|
||||
try (InputStream foo = getInputStreamFor("foo"); InputStream foo3 = getInputStreamFor("foo3")) {
|
||||
ConfigurationMetadataRepository repo = ConfigurationMetadataRepositoryJsonBuilder.create(foo, foo3).build();
|
||||
ConfigurationMetadataGroup group = repo.getAllGroups().get("spring.foo");
|
||||
ConfigurationMetadataSource fooSource = group.getSources().get("org.acme.Foo");
|
||||
assertThat(fooSource.getSourceMethod()).isEqualTo("foo()");
|
||||
assertThat(fooSource.getDescription()).isEqualTo("This is Foo.");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void emptyGroups() throws IOException {
|
||||
@ -185,10 +169,8 @@ class ConfigurationMetadataRepositoryJsonBuilderTests extends AbstractConfigurat
|
||||
|
||||
@Test
|
||||
void builderInstancesAreIsolated() throws IOException {
|
||||
try (InputStream foo = getInputStreamFor("foo")) {
|
||||
try (InputStream bar = getInputStreamFor("bar")) {
|
||||
ConfigurationMetadataRepositoryJsonBuilder builder = ConfigurationMetadataRepositoryJsonBuilder
|
||||
.create();
|
||||
try (InputStream foo = getInputStreamFor("foo"); InputStream bar = getInputStreamFor("bar")) {
|
||||
ConfigurationMetadataRepositoryJsonBuilder builder = ConfigurationMetadataRepositoryJsonBuilder.create();
|
||||
ConfigurationMetadataRepository firstRepo = builder.withJsonResource(foo).build();
|
||||
validateFoo(firstRepo);
|
||||
ConfigurationMetadataRepository secondRepo = builder.withJsonResource(bar).build();
|
||||
@ -202,7 +184,6 @@ class ConfigurationMetadataRepositoryJsonBuilderTests extends AbstractConfigurat
|
||||
assertThat(secondRepo.getAllProperties()).hasSize(6);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private void validateFoo(ConfigurationMetadataRepository repo) {
|
||||
ConfigurationMetadataGroup group = repo.getAllGroups().get("spring.foo");
|
||||
|
@ -25,7 +25,7 @@ import org.testcontainers.junit.jupiter.Testcontainers;
|
||||
* @author Christoph Dreis
|
||||
*/
|
||||
@Testcontainers(disabledWithoutDocker = true)
|
||||
public class TomEEDeploymentIntegrationTests extends AbstractDeploymentIntegrationTests {
|
||||
class TomEEDeploymentIntegrationTests extends AbstractDeploymentIntegrationTests {
|
||||
|
||||
@Container
|
||||
static WarDeploymentContainer container = new WarDeploymentContainer("tomee:8-jre-8.0.2-webprofile",
|
||||
|
@ -25,7 +25,7 @@ import org.testcontainers.junit.jupiter.Testcontainers;
|
||||
* @author Christoph Dreis
|
||||
*/
|
||||
@Testcontainers(disabledWithoutDocker = true)
|
||||
public class TomcatDeploymentIntegrationTests extends AbstractDeploymentIntegrationTests {
|
||||
class TomcatDeploymentIntegrationTests extends AbstractDeploymentIntegrationTests {
|
||||
|
||||
@Container
|
||||
static WarDeploymentContainer container = new WarDeploymentContainer("tomcat:9.0.37-jdk8-openjdk",
|
||||
|
@ -25,7 +25,7 @@ import org.testcontainers.junit.jupiter.Testcontainers;
|
||||
* @author Christoph Dreis
|
||||
*/
|
||||
@Testcontainers(disabledWithoutDocker = true)
|
||||
public class WildflyDeploymentIntegrationTests extends AbstractDeploymentIntegrationTests {
|
||||
class WildflyDeploymentIntegrationTests extends AbstractDeploymentIntegrationTests {
|
||||
|
||||
@Container
|
||||
static WarDeploymentContainer container = new WarDeploymentContainer("jboss/wildfly:20.0.1.Final",
|
||||
|
Loading…
Reference in New Issue
Block a user