From 0ce3420fcb6f868d967763e0f53dde68a36dce0b Mon Sep 17 00:00:00 2001 From: Moritz Halbritter Date: Wed, 3 Jul 2024 10:40:59 +0200 Subject: [PATCH] Polish "Publish an AuditEvent on logout" See gh-41278 --- .../boot/actuate/security/AuthenticationAuditListener.java | 4 +--- .../actuate/security/AuthenticationAuditListenerTests.java | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/security/AuthenticationAuditListener.java b/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/security/AuthenticationAuditListener.java index a7e1e87725f..13beb48e306 100644 --- a/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/security/AuthenticationAuditListener.java +++ b/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/security/AuthenticationAuditListener.java @@ -53,8 +53,7 @@ public class AuthenticationAuditListener extends AbstractAuthenticationAuditList public static final String AUTHENTICATION_SWITCH = "AUTHENTICATION_SWITCH"; /** - * This constant is used to indicate that the logout process - * has been completed successfully. + * Logout success event type. * * @since 3.4.0 */ @@ -111,7 +110,6 @@ public class AuthenticationAuditListener extends AbstractAuthenticationAuditList data.put("details", event.getAuthentication().getDetails()); } publish(new AuditEvent(event.getAuthentication().getName(), LOGOUT_SUCCESS, data)); - } private static final class WebAuditListener { diff --git a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/security/AuthenticationAuditListenerTests.java b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/security/AuthenticationAuditListenerTests.java index 04d22ab9ad5..2b68d1dfd8e 100644 --- a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/security/AuthenticationAuditListenerTests.java +++ b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/security/AuthenticationAuditListenerTests.java @@ -62,7 +62,7 @@ class AuthenticationAuditListenerTests { } @Test - void testLogoutSucess() { + void testLogoutSuccess() { AuditApplicationEvent event = handleAuthenticationEvent( new LogoutSuccessEvent(new UsernamePasswordAuthenticationToken("user", "password"))); assertThat(event.getAuditEvent().getType()).isEqualTo(AuthenticationAuditListener.LOGOUT_SUCCESS);