Spring/spring-boot
Spring/spring-boot
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-boot.git synced 2024-09-03 04:26:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Polish "Fix NPE in configprops endpoint"

Browse Source 
See gh-30068
This commit is contained in:
Andy Wilkinson 2022-04-07 19:42:19 +01:00
parent a1fe05f40b
commit 35154a96f3
3 changed files with 30 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/context/properties/ConfigurationPropertiesReportEndpoint.java
View File

@ -121,7 +121,7 @@ public class ConfigurationPropertiesReportEndpoint implements ApplicationContext
@ReadOperation @ReadOperation
public ApplicationConfigurationProperties configurationProperties() { public ApplicationConfigurationProperties configurationProperties() {
return extract(this.context, (bean) -> bean != null); return extract(this.context, (bean) -> true);
} }
@ReadOperation @ReadOperation

21
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/properties/ConfigurationPropertiesBean.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2012-2020 the original author or authors. * Copyright 2012-2022 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -143,14 +143,12 @@ public final class ConfigurationPropertiesBean {
return getAll((ConfigurableApplicationContext) applicationContext); return getAll((ConfigurableApplicationContext) applicationContext);
} }
Map<String, ConfigurationPropertiesBean> propertiesBeans = new LinkedHashMap<>(); Map<String, ConfigurationPropertiesBean> propertiesBeans = new LinkedHashMap<>();
applicationContext.getBeansWithAnnotation(ConfigurationProperties.class) applicationContext.getBeansWithAnnotation(ConfigurationProperties.class).forEach((beanName, bean) -> {
.forEach((beanName, bean) -> { ConfigurationPropertiesBean propertiesBean = get(applicationContext, bean, beanName);
ConfigurationPropertiesBean propertiesBean = get(applicationContext, bean, beanName); if (propertiesBean != null) {
if (propertiesBean == null) { //ignore for null propertiesBeans.put(beanName, propertiesBean);
return; }
} });
propertiesBeans.put(beanName,propertiesBean);
});
return propertiesBeans; return propertiesBeans;
} }
@ -164,10 +162,9 @@ public final class ConfigurationPropertiesBean {
try { try {
Object bean = beanFactory.getBean(beanName); Object bean = beanFactory.getBean(beanName);
ConfigurationPropertiesBean propertiesBean = get(applicationContext, bean, beanName); ConfigurationPropertiesBean propertiesBean = get(applicationContext, bean, beanName);
if (propertiesBean == null) { //ignore for null if (propertiesBean != null) {
continue; propertiesBeans.put(beanName, propertiesBean);
} }
propertiesBeans.put(beanName, propertiesBean);
} }
catch (Exception ex) { catch (Exception ex) {
} }

20
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/properties/ConfigurationPropertiesBeanTests.java
View File

@ -78,6 +78,15 @@ class ConfigurationPropertiesBeanTests {
} }
} }
@Test
void getAllDoesNotFindABeanDeclaredInAStaticBeanMethodOnAConfigurationAndConfigurationPropertiesAnnotatedClass() {
try (AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(
StaticBeanMethodConfiguration.class)) {
Map<String, ConfigurationPropertiesBean> all = ConfigurationPropertiesBean.getAll(context);
assertThat(all).containsOnlyKeys("configurationPropertiesBeanTests.StaticBeanMethodConfiguration");
}
}
@Test @Test
void getAllWhenHasBadBeanDoesNotFail() { void getAllWhenHasBadBeanDoesNotFail() {
try (AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext( try (AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(
@ -521,4 +530,15 @@ class ConfigurationPropertiesBeanTests {
} }
@Configuration(proxyBeanMethods = false)
@ConfigurationProperties
static class StaticBeanMethodConfiguration {
@Bean
static String stringBean() {
return "example";
}
}
} }