From 74b704b43c57709608d63d1d921a9b7cf1fb9a71 Mon Sep 17 00:00:00 2001 From: izeye Date: Sat, 12 Dec 2020 15:50:54 +0900 Subject: [PATCH] Add note for SPRING_PROFILES_ACTIVE in contributing guide See gh-24478 --- CONTRIBUTING.adoc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.adoc b/CONTRIBUTING.adoc index 7c98feda8b1..f6046394c3f 100755 --- a/CONTRIBUTING.adoc +++ b/CONTRIBUTING.adoc @@ -67,7 +67,9 @@ added after the original pull request but before a merge. * Add some Javadocs. * A few unit tests would help a lot as well -- someone has to do it. * Verification tasks, including tests and Checkstyle, can be executed - by running `./gradlew check` from the project root. + by running `./gradlew check` from the project root. Note that `SPRING_PROFILES_ACTIVE` + environment variable might affect the result of tests, so in that case, you can prevent + it by running `unset SPRING_PROFILES_ACTIVE` before running the task. * If no-one else is using your branch, please rebase it against the current master (or other target branch in the main project). * When writing a commit message please follow https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],