Spring/spring-boot
Spring/spring-boot
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-boot.git synced 2024-08-29 03:06:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix JarUrlTests

Browse Source 
Fix `JarUrlTests` to use the jarFile rather than temp.
This commit is contained in:
Phillip Webb 2023-12-06 15:57:44 -08:00
parent fc1a5033e8
commit 847daf484c
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
spring-boot-project/spring-boot-tools/spring-boot-loader/src/test/java/org/springframework/boot/loader/net/protocol/jar/JarUrlTests.java
View File

@ -44,43 +44,43 @@ class JarUrlTests {
@BeforeEach @BeforeEach
void setup() throws MalformedURLException { void setup() throws MalformedURLException {
this.jarFile = new File(this.temp, "my.jar"); this.jarFile = new File(this.temp, "my.jar");
this.jarFileUrlPath = this.temp.toURI().toURL().toString().substring("file:".length()); this.jarFileUrlPath = this.jarFile.toURI().toURL().toString().substring("file:".length()).replace("!", "%21");
} }
@Test @Test
void createWithFileReturnsUrl() { void createWithFileReturnsUrl() {
URL url = JarUrl.create(this.temp); URL url = JarUrl.create(this.jarFile);
assertThat(url).hasToString("jar:file:%s!/".formatted(this.jarFileUrlPath)); assertThat(url).hasToString("jar:file:%s!/".formatted(this.jarFileUrlPath));
} }
@Test @Test
void createWithFileAndEntryReturnsUrl() { void createWithFileAndEntryReturnsUrl() {
JarEntry entry = new JarEntry("lib.jar"); JarEntry entry = new JarEntry("lib.jar");
URL url = JarUrl.create(this.temp, entry); URL url = JarUrl.create(this.jarFile, entry);
assertThat(url).hasToString("jar:nested:%s/!lib.jar!/".formatted(this.jarFileUrlPath)); assertThat(url).hasToString("jar:nested:%s/!lib.jar!/".formatted(this.jarFileUrlPath));
} }
@Test @Test
void createWithFileAndNullEntryReturnsUrl() { void createWithFileAndNullEntryReturnsUrl() {
URL url = JarUrl.create(this.temp, (JarEntry) null); URL url = JarUrl.create(this.jarFile, (JarEntry) null);
assertThat(url).hasToString("jar:file:%s!/".formatted(this.jarFileUrlPath)); assertThat(url).hasToString("jar:file:%s!/".formatted(this.jarFileUrlPath));
} }
@Test @Test
void createWithFileAndNameReturnsUrl() { void createWithFileAndNameReturnsUrl() {
URL url = JarUrl.create(this.temp, "lib.jar"); URL url = JarUrl.create(this.jarFile, "lib.jar");
assertThat(url).hasToString("jar:nested:%s/!lib.jar!/".formatted(this.jarFileUrlPath)); assertThat(url).hasToString("jar:nested:%s/!lib.jar!/".formatted(this.jarFileUrlPath));
} }
@Test @Test
void createWithFileAndNullNameReturnsUrl() { void createWithFileAndNullNameReturnsUrl() {
URL url = JarUrl.create(this.temp, (String) null); URL url = JarUrl.create(this.jarFile, (String) null);
assertThat(url).hasToString("jar:file:%s!/".formatted(this.jarFileUrlPath)); assertThat(url).hasToString("jar:file:%s!/".formatted(this.jarFileUrlPath));
} }
@Test @Test
void createWithFileNameAndPathReturnsUrl() { void createWithFileNameAndPathReturnsUrl() {
URL url = JarUrl.create(this.temp, "lib.jar", "com/example/My.class"); URL url = JarUrl.create(this.jarFile, "lib.jar", "com/example/My.class");
assertThat(url).hasToString("jar:nested:%s/!lib.jar!/com/example/My.class".formatted(this.jarFileUrlPath)); assertThat(url).hasToString("jar:nested:%s/!lib.jar!/com/example/My.class".formatted(this.jarFileUrlPath));
} }