Spring/spring-boot
Spring/spring-boot
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-boot.git synced 2024-07-15 01:07:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not turn a null Flyway-specific password into an empty string

Browse Source 
It prevents using PGPASS for authentication with Postgres.

Fixes gh-35110
This commit is contained in:
Andy Wilkinson 2023-04-24 14:44:04 +01:00
parent be698cf6ed
commit 90952a2dd9
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayProperties.java
View File

@ -1,5 +1,5 @@
/*
* Copyright 2012-2022 the original author or authors.
* Copyright 2012-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -601,7 +601,7 @@ public class FlywayProperties {
}
public String getPassword() {
return (this.password != null) ? this.password : "";
return this.password;
}
public void setPassword(String password) {

2
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfigurationTests.java
View File

@ -154,7 +154,7 @@ class FlywayAutoConfigurationTests {
DataSource dataSource = context.getBean(Flyway.class).getConfiguration().getDataSource();
assertThat(dataSource).isNotNull();
assertThat(dataSource).hasFieldOrPropertyWithValue("username", null);
assertThat(dataSource).hasFieldOrPropertyWithValue("password", "");
assertThat(dataSource).hasFieldOrPropertyWithValue("password", null);
});
}