Spring/spring-boot
Spring/spring-boot
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-boot.git synced 2024-07-05 00:56:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Polish "Use 'switch' instead of 'if'"

Browse Source 
See gh-40985
This commit is contained in:
Phillip Webb 2024-06-11 12:18:32 -07:00
parent 2c5934dab2
commit a18cb37657
1 changed files with 20 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
buildSrc/src/main/java/org/springframework/boot/build/classpath/CheckClasspathForProhibitedDependencies.java
View File

@ -16,6 +16,7 @@
package org.springframework.boot.build.classpath; package org.springframework.boot.build.classpath;
import java.util.Set;
import java.util.TreeSet; import java.util.TreeSet;
import java.util.stream.Collectors; import java.util.stream.Collectors;
@ -35,6 +36,11 @@ import org.gradle.api.tasks.TaskAction;
*/ */
public class CheckClasspathForProhibitedDependencies extends DefaultTask { public class CheckClasspathForProhibitedDependencies extends DefaultTask {
private static final Set<String> PROHIBITED_GROUPS = Set.of("org.codehaus.groovy", "org.eclipse.jetty.toolchain",
"commons-logging", "org.apache.geronimo.specs", "com.sun.activation");
private static final Set<String> PERMITTED_JAVAX_GROUPS = Set.of("javax.batch", "javax.cache", "javax.money");
private Configuration classpath; private Configuration classpath;
public CheckClasspathForProhibitedDependencies() { public CheckClasspathForProhibitedDependencies() {
@ -69,29 +75,20 @@ public class CheckClasspathForProhibitedDependencies extends DefaultTask {
} }
private boolean prohibited(ModuleVersionIdentifier id) { private boolean prohibited(ModuleVersionIdentifier id) {
String group = id.getGroup(); return PROHIBITED_GROUPS.contains(id.getGroup()) || prohibitedJavax(id) || prohibitedSlf4j(id)
switch (group) { || prohibitedJbossSpec(id);
case "javax.batch", "javax.cache", "javax.money" -> { }
return false;
} private boolean prohibitedSlf4j(ModuleVersionIdentifier id) {
case "commons-logging", "org.codehaus.groovy", "org.eclipse.jetty.toolchain", return id.getGroup().equals("org.slf4j") && id.getName().equals("jcl-over-slf4j");
"org.apache.geronimo.specs" -> { }
return true;
} private boolean prohibitedJbossSpec(ModuleVersionIdentifier id) {
} return id.getGroup().startsWith("org.jboss.spec");
if (group.startsWith("javax")) { }
return true;
} private boolean prohibitedJavax(ModuleVersionIdentifier id) {
if (group.equals("org.slf4j") && id.getName().equals("jcl-over-slf4j")) { return id.getGroup().startsWith("javax.") && !PERMITTED_JAVAX_GROUPS.contains(id.getGroup());
return true;
}
if (group.startsWith("org.jboss.spec")) {
return true;
}
if (group.equals("org.apache.geronimo.specs")) {
return true;
}
return group.equals("com.sun.activation");
} }
} }