Remove the second parameter of substring() if possible

Closes gh-5720
This commit is contained in:
Johnny Lim 2016-04-18 19:00:35 +09:00 committed by Stephane Nicoll
parent 58dac43b8d
commit b914b4aa52
7 changed files with 7 additions and 8 deletions

View File

@ -76,7 +76,7 @@ public class ProjectInfoAutoConfiguration {
Properties target = new Properties();
for (String key : source.stringPropertyNames()) {
if (key.startsWith(p)) {
target.put(key.substring(p.length(), key.length()), source.get(key));
target.put(key.substring(p.length()), source.get(key));
}
}
return target;

View File

@ -250,8 +250,7 @@ class InitializrService {
String value = header.getValue();
int start = value.indexOf(FILENAME_HEADER_PREFIX);
if (start != -1) {
value = value.substring(start + FILENAME_HEADER_PREFIX.length(),
value.length());
value = value.substring(start + FILENAME_HEADER_PREFIX.length());
int end = value.indexOf("\"");
if (end != -1) {
return value.substring(0, end);

View File

@ -81,7 +81,7 @@ class RawConfigurationMetadata {
String dottedPrefix = groupId + ".";
String id = item.getId();
if (hasLength(groupId) && id.startsWith(dottedPrefix)) {
String name = id.substring(dottedPrefix.length(), id.length());
String name = id.substring(dottedPrefix.length());
item.setName(name);
}
}

View File

@ -54,7 +54,7 @@ public class ItemHint implements Comparable<ItemHint> {
int dot = name.lastIndexOf('.');
if (dot != -1) {
String prefix = name.substring(0, dot);
String originalName = name.substring(dot, name.length());
String originalName = name.substring(dot);
return prefix + ConfigurationMetadata.toDashedCase(originalName);
}
return ConfigurationMetadata.toDashedCase(name);

View File

@ -29,7 +29,7 @@ public class SampleApplication {
throw new IllegalArgumentException("Invalid argument " + argument);
}
int index = args[0].indexOf("=");
String profile = argument.substring(index + 1, argument.length());
String profile = argument.substring(index + 1);
System.out.println("I haz been run with profile(s) '" + profile + "'");
}

View File

@ -29,7 +29,7 @@ public class SampleApplication {
throw new IllegalArgumentException("Invalid argument " + argument);
}
int index = args[0].indexOf("=");
String profile = argument.substring(index + 1, argument.length());
String profile = argument.substring(index + 1);
System.out.println("I haz been run with profile(s) '" + profile + "'");
}

View File

@ -464,7 +464,7 @@ public class ConfigFileApplicationListenerTests {
assertThat(index)
.as("Loading profile '" + profile + "' not found in '" + log + "'")
.isNotEqualTo(-1);
log = log.substring(index + line.length(), log.length());
log = log.substring(index + line.length());
}
}