Spring/spring-boot
Spring/spring-boot
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-boot.git synced 2024-09-03 04:26:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use Awaitility instead of Thread.sleep

Browse Source 
See gh-21988
This commit is contained in:
Tomek Szmytka 2020-06-16 20:34:48 +02:00 committed by Andy Wilkinson
parent 67604a5416
commit c13385ea74
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
spring-boot-project/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/livereload/LiveReloadServerTests.java
View File

@ -45,6 +45,7 @@ import org.springframework.web.socket.client.standard.StandardWebSocketClient;
import org.springframework.web.socket.handler.TextWebSocketHandler; import org.springframework.web.socket.handler.TextWebSocketHandler;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.awaitility.Awaitility.await;
import static org.hamcrest.Matchers.empty; import static org.hamcrest.Matchers.empty;
import static org.hamcrest.Matchers.is; import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.not; import static org.hamcrest.Matchers.not;
@ -88,17 +89,16 @@ class LiveReloadServerTests {
void triggerReload() throws Exception { void triggerReload() throws Exception {
LiveReloadWebSocketHandler handler = connect(); LiveReloadWebSocketHandler handler = connect();
this.server.triggerReload(); this.server.triggerReload();
Thread.sleep(200); await().atMost(Duration.ofSeconds(1)).until(handler::getMessages,
assertThat(handler.getMessages().get(0)).contains("http://livereload.com/protocols/official-7"); (msgs) -> msgs.get(0).contains("http://livereload.com/protocols/official-7")
assertThat(handler.getMessages().get(1)).contains("command\":\"reload\""); && msgs.get(1).contains("command\":\"reload\""));
} }
@Test @Test
void pingPong() throws Exception { void pingPong() throws Exception {
LiveReloadWebSocketHandler handler = connect(); LiveReloadWebSocketHandler handler = connect();
handler.sendMessage(new PingMessage()); handler.sendMessage(new PingMessage());
Thread.sleep(200); await().atMost(Duration.ofSeconds(1)).until(handler::getPongCount, is(1));
assertThat(handler.getPongCount()).isEqualTo(1);
} }
@Test @Test
@ -117,8 +117,7 @@ class LiveReloadServerTests {
void serverClose() throws Exception { void serverClose() throws Exception {
LiveReloadWebSocketHandler handler = connect(); LiveReloadWebSocketHandler handler = connect();
this.server.stop(); this.server.stop();
Thread.sleep(200); await().atMost(Duration.ofSeconds(1)).until(() -> handler.getCloseStatus().getCode(), is(1006));
assertThat(handler.getCloseStatus().getCode()).isEqualTo(1006);
} }
private LiveReloadWebSocketHandler connect() throws Exception { private LiveReloadWebSocketHandler connect() throws Exception {