mirror of
https://github.com/spring-projects/spring-boot.git
synced 2024-07-05 00:56:58 +08:00
Polish "Replace calls to verifyComplete() to avoid indefinite blocking"
See gh-35915
This commit is contained in:
parent
f9da30faf1
commit
d2966e1cbf
@ -74,7 +74,9 @@ public abstract class ArchitectureCheck extends DefaultTask {
|
||||
.importPaths(this.classes.getFiles().stream().map(File::toPath).collect(Collectors.toList()));
|
||||
List<EvaluationResult> violations = Stream.of(allPackagesShouldBeFreeOfTangles(),
|
||||
allBeanPostProcessorBeanMethodsShouldBeStaticAndHaveParametersThatWillNotCausePrematureInitialization(),
|
||||
allBeanFactoryPostProcessorBeanMethodsShouldBeStaticAndHaveNoParameters())
|
||||
allBeanFactoryPostProcessorBeanMethodsShouldBeStaticAndHaveNoParameters(),
|
||||
noClassesShouldCallStepVerifierStepVerifyComplete(),
|
||||
noClassesShouldConfigureDefaultStepVerifierTimeout())
|
||||
.map((rule) -> rule.evaluate(javaClasses))
|
||||
.filter(EvaluationResult::hasViolation)
|
||||
.collect(Collectors.toList());
|
||||
@ -163,6 +165,20 @@ public abstract class ArchitectureCheck extends DefaultTask {
|
||||
};
|
||||
}
|
||||
|
||||
private ArchRule noClassesShouldCallStepVerifierStepVerifyComplete() {
|
||||
return ArchRuleDefinition.noClasses()
|
||||
.should()
|
||||
.callMethod("reactor.test.StepVerifier$Step", "verifyComplete")
|
||||
.because("it can block indefinitely and expectComplete().verify(Duration) should be used instead");
|
||||
}
|
||||
|
||||
private ArchRule noClassesShouldConfigureDefaultStepVerifierTimeout() {
|
||||
return ArchRuleDefinition.noClasses()
|
||||
.should()
|
||||
.callMethod("reactor.test.StepVerifier", "setDefaultTimeout", "java.time.Duration")
|
||||
.because("expectComplete().verify(Duration) should be used instead");
|
||||
}
|
||||
|
||||
public void setClasses(FileCollection classes) {
|
||||
this.classes = classes;
|
||||
}
|
||||
|
@ -16,6 +16,8 @@
|
||||
|
||||
package org.springframework.boot.actuate.autoconfigure.cloudfoundry.reactive;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import org.junit.jupiter.api.BeforeEach;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
@ -33,8 +35,6 @@ import org.springframework.mock.http.server.reactive.MockServerHttpRequest;
|
||||
import org.springframework.mock.web.server.MockServerWebExchange;
|
||||
import org.springframework.util.Base64Utils;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.mockito.ArgumentMatchers.any;
|
||||
import static org.mockito.BDDMockito.given;
|
||||
@ -68,7 +68,8 @@ class ReactiveCloudFoundrySecurityInterceptorTests {
|
||||
.build());
|
||||
StepVerifier.create(this.interceptor.preHandle(request, "/a"))
|
||||
.consumeNextWith((response) -> assertThat(response.getStatus()).isEqualTo(HttpStatus.OK))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -77,7 +78,8 @@ class ReactiveCloudFoundrySecurityInterceptorTests {
|
||||
StepVerifier.create(this.interceptor.preHandle(request, "/a"))
|
||||
.consumeNextWith(
|
||||
(response) -> assertThat(response.getStatus()).isEqualTo(Reason.MISSING_AUTHORIZATION.getStatus()))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -87,7 +89,8 @@ class ReactiveCloudFoundrySecurityInterceptorTests {
|
||||
StepVerifier.create(this.interceptor.preHandle(request, "/a"))
|
||||
.consumeNextWith(
|
||||
(response) -> assertThat(response.getStatus()).isEqualTo(Reason.MISSING_AUTHORIZATION.getStatus()))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -123,7 +126,8 @@ class ReactiveCloudFoundrySecurityInterceptorTests {
|
||||
.build());
|
||||
StepVerifier.create(this.interceptor.preHandle(request, "/a"))
|
||||
.consumeNextWith((response) -> assertThat(response.getStatus()).isEqualTo(Reason.ACCESS_DENIED.getStatus()))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -137,7 +141,7 @@ class ReactiveCloudFoundrySecurityInterceptorTests {
|
||||
StepVerifier.create(this.interceptor.preHandle(exchange, "/a")).consumeNextWith((response) -> {
|
||||
assertThat(response.getStatus()).isEqualTo(HttpStatus.OK);
|
||||
assertThat((AccessLevel) exchange.getAttribute("cloudFoundryAccessLevel")).isEqualTo(AccessLevel.FULL);
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -153,7 +157,7 @@ class ReactiveCloudFoundrySecurityInterceptorTests {
|
||||
assertThat(response.getStatus()).isEqualTo(HttpStatus.OK);
|
||||
assertThat((AccessLevel) exchange.getAttribute("cloudFoundryAccessLevel"))
|
||||
.isEqualTo(AccessLevel.RESTRICTED);
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
private String mockAccessToken() {
|
||||
|
@ -122,7 +122,8 @@ class ReactiveTokenValidatorTests {
|
||||
String claims = "{\"exp\": 2147483647, \"iss\": \"http://localhost:8080/uaa/oauth/token\", \"scope\": [\"actuator.read\"]}";
|
||||
StepVerifier
|
||||
.create(this.tokenValidator.validate(new Token(getSignedToken(header.getBytes(), claims.getBytes()))))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
assertThat(this.tokenValidator).hasFieldOrPropertyWithValue("cachedTokenKeys", VALID_KEYS);
|
||||
fetchTokenKeys.assertWasSubscribed();
|
||||
}
|
||||
@ -136,7 +137,8 @@ class ReactiveTokenValidatorTests {
|
||||
String claims = "{\"exp\": 2147483647, \"iss\": \"http://localhost:8080/uaa/oauth/token\", \"scope\": [\"actuator.read\"]}";
|
||||
StepVerifier
|
||||
.create(this.tokenValidator.validate(new Token(getSignedToken(header.getBytes(), claims.getBytes()))))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
assertThat(this.tokenValidator).hasFieldOrPropertyWithValue("cachedTokenKeys", VALID_KEYS);
|
||||
fetchTokenKeys.assertWasSubscribed();
|
||||
}
|
||||
@ -168,7 +170,8 @@ class ReactiveTokenValidatorTests {
|
||||
String claims = "{\"exp\": 2147483647, \"iss\": \"http://localhost:8080/uaa/oauth/token\", \"scope\": [\"actuator.read\"]}";
|
||||
StepVerifier
|
||||
.create(this.tokenValidator.validate(new Token(getSignedToken(header.getBytes(), claims.getBytes()))))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
fetchTokenKeys.assertWasNotSubscribed();
|
||||
}
|
||||
|
||||
|
@ -62,7 +62,8 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.UP))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -72,7 +73,8 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.DOWN))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -82,7 +84,8 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.DOWN))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -92,7 +95,8 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.DOWN))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -102,7 +106,8 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.UP))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -112,7 +117,8 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.UP))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -122,7 +128,8 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.UP))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -140,7 +147,7 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
assertThat(h.getStatus()).isEqualTo(Status.UP);
|
||||
assertThat(h.getDetails()).containsOnlyKeys("version");
|
||||
assertThat(h.getDetails().get("version")).isEqualTo(Version.V4_0_0);
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -151,7 +158,7 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
StepVerifier.create(health).consumeNextWith((h) -> {
|
||||
assertThat(h.getStatus()).isEqualTo(Status.UP);
|
||||
assertThat(h.getDetails().get("version")).isNull();
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -166,7 +173,7 @@ class CassandraDriverReactiveHealthIndicatorTests {
|
||||
assertThat(h.getDetails()).containsOnlyKeys("error");
|
||||
assertThat(h.getDetails().get("error"))
|
||||
.isEqualTo(DriverTimeoutException.class.getName() + ": Test Exception");
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
private CqlSession mockCqlSessionWithNodeState(NodeState... nodeStates) {
|
||||
|
@ -37,7 +37,7 @@ class HealthIndicatorReactiveAdapterTests {
|
||||
HealthIndicatorReactiveAdapter adapter = new HealthIndicatorReactiveAdapter(delegate);
|
||||
Health status = Health.up().build();
|
||||
given(delegate.health()).willReturn(status);
|
||||
StepVerifier.create(adapter.health()).expectNext(status).expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(adapter.health()).expectNext(status).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -55,7 +55,10 @@ class HealthIndicatorReactiveAdapterTests {
|
||||
.status(Thread.currentThread().getName().equals(currentThread) ? Status.DOWN : Status.UP)
|
||||
.build();
|
||||
HealthIndicatorReactiveAdapter adapter = new HealthIndicatorReactiveAdapter(delegate);
|
||||
StepVerifier.create(adapter.health()).expectNext(Health.status(Status.UP).build()).expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(adapter.health())
|
||||
.expectNext(Health.status(Status.UP).build())
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
}
|
||||
|
@ -16,6 +16,8 @@
|
||||
|
||||
package org.springframework.boot.actuate.health;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import reactor.core.publisher.Mono;
|
||||
@ -25,8 +27,6 @@ import org.springframework.boot.actuate.health.Health.Builder;
|
||||
import org.springframework.boot.test.system.CapturedOutput;
|
||||
import org.springframework.boot.test.system.OutputCaptureExtension;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
/**
|
||||
@ -42,7 +42,8 @@ class ReactiveHealthIndicatorImplementationTests {
|
||||
void healthUp(CapturedOutput output) {
|
||||
StepVerifier.create(new SimpleReactiveHealthIndicator().health())
|
||||
.consumeNextWith((health) -> assertThat(health).isEqualTo(Health.up().build()))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
assertThat(output).doesNotContain("Health check failed for simple");
|
||||
}
|
||||
|
||||
@ -51,7 +52,8 @@ class ReactiveHealthIndicatorImplementationTests {
|
||||
StepVerifier.create(new CustomErrorMessageReactiveHealthIndicator().health())
|
||||
.consumeNextWith(
|
||||
(health) -> assertThat(health).isEqualTo(Health.down(new UnsupportedOperationException()).build()))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
assertThat(output).contains("Health check failed for custom");
|
||||
}
|
||||
|
||||
@ -59,7 +61,8 @@ class ReactiveHealthIndicatorImplementationTests {
|
||||
void healthDownWithCustomErrorMessageFunction(CapturedOutput output) {
|
||||
StepVerifier.create(new CustomErrorMessageFunctionReactiveHealthIndicator().health())
|
||||
.consumeNextWith((health) -> assertThat(health).isEqualTo(Health.down(new RuntimeException()).build()))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
assertThat(output).contains("Health check failed with RuntimeException");
|
||||
}
|
||||
|
||||
|
@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2021 the original author or authors.
|
||||
* Copyright 2012-2023 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@ -60,7 +60,7 @@ class ConnectionPoolMetricsTests {
|
||||
@AfterEach
|
||||
void close() {
|
||||
if (this.connectionFactory != null) {
|
||||
StepVerifier.create(this.connectionFactory.close()).expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(this.connectionFactory.close()).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
}
|
||||
|
||||
@ -73,8 +73,16 @@ class ConnectionPoolMetricsTests {
|
||||
Tags.of(testTag, regionTag));
|
||||
metrics.bindTo(registry);
|
||||
// acquire two connections
|
||||
connectionPool.create().as(StepVerifier::create).expectNextCount(1).expectComplete().verify(Duration.ofSeconds(5));
|
||||
connectionPool.create().as(StepVerifier::create).expectNextCount(1).expectComplete().verify(Duration.ofSeconds(5));
|
||||
connectionPool.create()
|
||||
.as(StepVerifier::create)
|
||||
.expectNextCount(1)
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
connectionPool.create()
|
||||
.as(StepVerifier::create)
|
||||
.expectNextCount(1)
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
assertGauge(registry, "r2dbc.pool.acquired", 2);
|
||||
assertGauge(registry, "r2dbc.pool.allocated", 3);
|
||||
assertGauge(registry, "r2dbc.pool.idle", 1);
|
||||
|
@ -162,7 +162,7 @@ class MetricsWebFilterTests {
|
||||
exchange.getResponse().setRawStatusCode(500);
|
||||
return exchange.getResponse().setComplete();
|
||||
});
|
||||
StepVerifier.create(processing).expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(processing).expectComplete().verify(Duration.ofSeconds(30));
|
||||
assertMetricsContainsTag("uri", "/projects/{project}");
|
||||
assertMetricsContainsTag("status", "500");
|
||||
assertMetricsContainsTag("outcome", "UNKNOWN");
|
||||
|
@ -16,6 +16,8 @@
|
||||
|
||||
package org.springframework.boot.actuate.mongo;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import com.mongodb.MongoException;
|
||||
import org.bson.Document;
|
||||
import org.junit.jupiter.api.Test;
|
||||
@ -26,8 +28,6 @@ import org.springframework.boot.actuate.health.Health;
|
||||
import org.springframework.boot.actuate.health.Status;
|
||||
import org.springframework.data.mongodb.core.ReactiveMongoTemplate;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.mockito.BDDMockito.given;
|
||||
import static org.mockito.Mockito.mock;
|
||||
@ -52,7 +52,7 @@ class MongoReactiveHealthIndicatorTests {
|
||||
assertThat(h.getStatus()).isEqualTo(Status.UP);
|
||||
assertThat(h.getDetails()).containsOnlyKeys("version");
|
||||
assertThat(h.getDetails().get("version")).isEqualTo("2.6.4");
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -67,7 +67,7 @@ class MongoReactiveHealthIndicatorTests {
|
||||
assertThat(h.getStatus()).isEqualTo(Status.DOWN);
|
||||
assertThat(h.getDetails()).containsOnlyKeys("error");
|
||||
assertThat(h.getDetails().get("error")).isEqualTo(MongoException.class.getName() + ": Connection failed");
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
}
|
||||
|
@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2022 the original author or authors.
|
||||
* Copyright 2012-2023 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@ -59,7 +59,7 @@ class Neo4jReactiveHealthIndicatorTests {
|
||||
assertThat(health.getStatus()).isEqualTo(Status.UP);
|
||||
assertThat(health.getDetails()).containsEntry("server", "4711@My Home");
|
||||
assertThat(health.getDetails()).containsEntry("edition", "ultimate collectors edition");
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -81,7 +81,7 @@ class Neo4jReactiveHealthIndicatorTests {
|
||||
assertThat(health.getStatus()).isEqualTo(Status.UP);
|
||||
assertThat(health.getDetails()).containsEntry("server", "4711@My Home");
|
||||
assertThat(health.getDetails()).containsEntry("edition", "some edition");
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
then(session).should(times(2)).close();
|
||||
}
|
||||
|
||||
@ -93,7 +93,7 @@ class Neo4jReactiveHealthIndicatorTests {
|
||||
healthIndicator.health().as(StepVerifier::create).consumeNextWith((health) -> {
|
||||
assertThat(health.getStatus()).isEqualTo(Status.DOWN);
|
||||
assertThat(health.getDetails()).containsKeys("error");
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
private RxResult mockStatementResult(ResultSummary resultSummary, String version, String edition) {
|
||||
|
@ -57,10 +57,10 @@ class ConnectionFactoryHealthIndicatorTests {
|
||||
assertThat(actual.getStatus()).isEqualTo(Status.UP);
|
||||
assertThat(actual.getDetails()).containsOnly(entry("database", "H2"),
|
||||
entry("validationQuery", "validate(REMOTE)"));
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
finally {
|
||||
StepVerifier.create(connectionFactory.close()).expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(connectionFactory.close()).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
}
|
||||
|
||||
@ -75,7 +75,7 @@ class ConnectionFactoryHealthIndicatorTests {
|
||||
assertThat(actual.getStatus()).isEqualTo(Status.DOWN);
|
||||
assertThat(actual.getDetails()).containsOnly(entry("database", "mock"),
|
||||
entry("validationQuery", "validate(REMOTE)"), entry("error", "java.lang.RuntimeException: test"));
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -91,7 +91,7 @@ class ConnectionFactoryHealthIndicatorTests {
|
||||
assertThat(actual.getStatus()).isEqualTo(Status.DOWN);
|
||||
assertThat(actual.getDetails()).containsOnly(entry("database", "mock"),
|
||||
entry("validationQuery", "validate(REMOTE)"));
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -105,17 +105,18 @@ class ConnectionFactoryHealthIndicatorTests {
|
||||
.flatMap(Result::getRowsUpdated)
|
||||
.thenMany(it.close()))
|
||||
.as(StepVerifier::create)
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
ReactiveHealthIndicator healthIndicator = new ConnectionFactoryHealthIndicator(connectionFactory,
|
||||
customValidationQuery);
|
||||
healthIndicator.health().as(StepVerifier::create).assertNext((actual) -> {
|
||||
assertThat(actual.getStatus()).isEqualTo(Status.UP);
|
||||
assertThat(actual.getDetails()).containsOnly(entry("database", "H2"), entry("result", 0L),
|
||||
entry("validationQuery", customValidationQuery));
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
finally {
|
||||
StepVerifier.create(connectionFactory.close()).expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(connectionFactory.close()).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
}
|
||||
@ -132,10 +133,10 @@ class ConnectionFactoryHealthIndicatorTests {
|
||||
assertThat(actual.getDetails()).contains(entry("database", "H2"),
|
||||
entry("validationQuery", invalidValidationQuery));
|
||||
assertThat(actual.getDetails()).containsOnlyKeys("database", "error", "validationQuery");
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
finally {
|
||||
StepVerifier.create(connectionFactory.close()).expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(connectionFactory.close()).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -63,7 +63,7 @@ class RedisReactiveHealthIndicatorTests {
|
||||
assertThat(h.getStatus()).isEqualTo(Status.UP);
|
||||
assertThat(h.getDetails()).containsOnlyKeys("version");
|
||||
assertThat(h.getDetails().get("version")).isEqualTo("2.8.9");
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
then(redisConnection).should().closeLater();
|
||||
}
|
||||
|
||||
@ -77,7 +77,7 @@ class RedisReactiveHealthIndicatorTests {
|
||||
assertThat(h.getDetails().get("cluster_size")).isEqualTo(4L);
|
||||
assertThat(h.getDetails().get("slots_up")).isEqualTo(4L);
|
||||
assertThat(h.getDetails().get("slots_fail")).isEqualTo(0L);
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
then(redisConnectionFactory.getReactiveConnection()).should().closeLater();
|
||||
}
|
||||
|
||||
@ -91,7 +91,7 @@ class RedisReactiveHealthIndicatorTests {
|
||||
assertThat(h.getDetails().get("cluster_size")).isEqualTo(4L);
|
||||
assertThat(h.getDetails().get("slots_up")).isEqualTo(4L);
|
||||
assertThat(h.getDetails().get("slots_fail")).isEqualTo(0L);
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -103,7 +103,7 @@ class RedisReactiveHealthIndicatorTests {
|
||||
assertThat(h.getStatus()).isEqualTo(Status.DOWN);
|
||||
assertThat(h.getDetails().get("slots_up")).isEqualTo(3L);
|
||||
assertThat(h.getDetails().get("slots_fail")).isEqualTo(1L);
|
||||
}).expectComplete().verify(Duration.ofSeconds(5));
|
||||
}).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
@ -116,7 +116,8 @@ class RedisReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.DOWN))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
then(redisConnection).should().closeLater();
|
||||
}
|
||||
|
||||
@ -129,7 +130,8 @@ class RedisReactiveHealthIndicatorTests {
|
||||
Mono<Health> health = healthIndicator.health();
|
||||
StepVerifier.create(health)
|
||||
.consumeNextWith((h) -> assertThat(h.getStatus()).isEqualTo(Status.DOWN))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
private RedisReactiveHealthIndicator createHealthIndicator(ReactiveRedisConnection redisConnection,
|
||||
|
@ -106,7 +106,8 @@ class HttpTraceWebFilterTests {
|
||||
private void executeFilter(ServerWebExchange exchange, WebFilterChain chain) {
|
||||
StepVerifier
|
||||
.create(this.filter.filter(exchange, chain).then(Mono.defer(() -> exchange.getResponse().setComplete())))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
}
|
||||
|
@ -16,6 +16,8 @@
|
||||
|
||||
package org.springframework.boot.autoconfigure.data.r2dbc;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import io.r2dbc.spi.ConnectionFactory;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import reactor.test.StepVerifier;
|
||||
@ -39,8 +41,6 @@ import org.springframework.data.repository.Repository;
|
||||
import org.springframework.r2dbc.connection.init.ResourceDatabasePopulator;
|
||||
import org.springframework.r2dbc.core.DatabaseClient;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
/**
|
||||
@ -82,7 +82,8 @@ class R2dbcRepositoriesAutoConfigurationTests {
|
||||
.findById(2000L)
|
||||
.as(StepVerifier::create)
|
||||
.expectNextCount(1)
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
});
|
||||
}
|
||||
|
||||
@ -105,7 +106,8 @@ class R2dbcRepositoriesAutoConfigurationTests {
|
||||
.findById(2000L)
|
||||
.as(StepVerifier::create)
|
||||
.expectNextCount(1)
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
});
|
||||
}
|
||||
|
||||
|
@ -16,6 +16,8 @@
|
||||
|
||||
package org.springframework.boot.autoconfigure.r2dbc;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import io.r2dbc.spi.Connection;
|
||||
import io.r2dbc.spi.ConnectionFactory;
|
||||
import org.junit.jupiter.api.Test;
|
||||
@ -33,8 +35,6 @@ import org.springframework.transaction.annotation.Transactional;
|
||||
import org.springframework.transaction.reactive.TransactionSynchronizationManager;
|
||||
import org.springframework.transaction.reactive.TransactionalOperator;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.mockito.BDDMockito.given;
|
||||
import static org.mockito.Mockito.mock;
|
||||
@ -67,7 +67,11 @@ class R2dbcTransactionManagerAutoConfigurationTests {
|
||||
this.contextRunner.withUserConfiguration(SingleConnectionFactoryConfiguration.class, BaseConfiguration.class)
|
||||
.run((context) -> {
|
||||
TransactionalService bean = context.getBean(TransactionalService.class);
|
||||
bean.isTransactionActive().as(StepVerifier::create).expectNext(true).expectComplete().verify(Duration.ofSeconds(5));
|
||||
bean.isTransactionActive()
|
||||
.as(StepVerifier::create)
|
||||
.expectNext(true)
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
});
|
||||
}
|
||||
|
||||
|
@ -83,8 +83,12 @@ class DataNeo4jTestReactiveIntegrationTests {
|
||||
.flatMap(this.exampleRepository::save)
|
||||
.as(StepVerifier::create)
|
||||
.expectNextCount(1)
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(this.neo4jTemplate.count(ExampleGraph.class)).expectNext(1L).expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
StepVerifier.create(this.neo4jTemplate.count(ExampleGraph.class))
|
||||
.expectNext(1L)
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
|
@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2012-2021 the original author or authors.
|
||||
* Copyright 2012-2023 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@ -16,6 +16,8 @@
|
||||
|
||||
package org.springframework.boot.test.autoconfigure.data.r2dbc;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import io.r2dbc.spi.ConnectionFactory;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import reactor.test.StepVerifier;
|
||||
@ -24,8 +26,6 @@ import org.springframework.beans.factory.annotation.Autowired;
|
||||
import org.springframework.context.ApplicationContext;
|
||||
import org.springframework.r2dbc.core.DatabaseClient;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
/**
|
||||
@ -48,7 +48,12 @@ class DataR2dbcTestIntegrationTests {
|
||||
|
||||
@Test
|
||||
void testDatabaseClient() {
|
||||
this.databaseClient.sql("SELECT * FROM example").fetch().all().as(StepVerifier::create).expectComplete().verify(Duration.ofSeconds(5));
|
||||
this.databaseClient.sql("SELECT * FROM example")
|
||||
.fetch()
|
||||
.all()
|
||||
.as(StepVerifier::create)
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
|
@ -63,11 +63,16 @@ class DataRedisTestReactiveIntegrationTests {
|
||||
String id = UUID.randomUUID().toString();
|
||||
StepVerifier.create(this.operations.opsForValue().set(id, "Hello World"))
|
||||
.expectNext(Boolean.TRUE)
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(this.operations.opsForValue().get(id)).expectNext("Hello World").expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
StepVerifier.create(this.operations.opsForValue().get(id))
|
||||
.expectNext("Hello World")
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
StepVerifier.create(this.operations.execute((action) -> action.serverCommands().flushDb()))
|
||||
.expectNext("OK")
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
|
@ -195,7 +195,7 @@ class NettyRSocketServerFactoryTests {
|
||||
private void checkEchoRequest() {
|
||||
String payload = "test payload";
|
||||
Mono<String> response = this.requester.route("test").data(payload).retrieveMono(String.class);
|
||||
StepVerifier.create(response).expectNext(payload).expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(response).expectNext(payload).expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
private void testBasicSslWithKeyStore(String keyStore, String keyPassword, Transport transport) {
|
||||
|
@ -109,8 +109,7 @@ class NettyReactiveWebServerFactoryTests extends AbstractReactiveWebServerFactor
|
||||
@Test
|
||||
void whenSslIsConfiguredWithAValidAliasARequestSucceeds() {
|
||||
Mono<String> result = testSslWithAlias("test-alias");
|
||||
StepVerifier.setDefaultTimeout(Duration.ofSeconds(30));
|
||||
StepVerifier.create(result).expectNext("Hello World").expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(result).expectNext("Hello World").expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
|
@ -55,7 +55,8 @@ class MustacheViewTests {
|
||||
.block(Duration.ofSeconds(30));
|
||||
StepVerifier.create(exchange.getResponse().getBodyAsString())
|
||||
.assertNext((body) -> assertThat(body).isEqualToIgnoringWhitespace("Hello Spring"))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
}
|
||||
|
@ -193,8 +193,7 @@ public abstract class AbstractReactiveWebServerFactoryTests {
|
||||
.retrieve()
|
||||
.bodyToMono(String.class);
|
||||
|
||||
StepVerifier.setDefaultTimeout(Duration.ofSeconds(30));
|
||||
StepVerifier.create(result).expectNext("Hello World").expectComplete().verify(Duration.ofSeconds(5));
|
||||
StepVerifier.create(result).expectNext("Hello World").expectComplete().verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
@Test
|
||||
|
@ -16,6 +16,8 @@
|
||||
|
||||
package smoketest.data.r2dbc;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.testcontainers.containers.PostgreSQLContainer;
|
||||
import org.testcontainers.junit.jupiter.Container;
|
||||
@ -28,8 +30,6 @@ import org.springframework.boot.testsupport.testcontainers.DockerImageNames;
|
||||
import org.springframework.test.context.DynamicPropertyRegistry;
|
||||
import org.springframework.test.context.DynamicPropertySource;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
/**
|
||||
@ -62,7 +62,8 @@ class CityRepositoryTests {
|
||||
void databaseHasBeenInitialized() {
|
||||
StepVerifier.create(this.repository.findByState("DC").filter((city) -> city.getName().equals("Washington")))
|
||||
.consumeNextWith((city) -> assertThat(city.getId()).isNotNull())
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
private static String r2dbcUrl() {
|
||||
|
@ -16,6 +16,8 @@
|
||||
|
||||
package smoketest.data.r2dbc;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.testcontainers.containers.PostgreSQLContainer;
|
||||
import org.testcontainers.junit.jupiter.Container;
|
||||
@ -28,8 +30,6 @@ import org.springframework.boot.testsupport.testcontainers.DockerImageNames;
|
||||
import org.springframework.test.context.DynamicPropertyRegistry;
|
||||
import org.springframework.test.context.DynamicPropertySource;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
/**
|
||||
@ -62,7 +62,8 @@ class CityRepositoryTests {
|
||||
void databaseHasBeenInitialized() {
|
||||
StepVerifier.create(this.repository.findByState("DC").filter((city) -> city.getName().equals("Washington")))
|
||||
.consumeNextWith((city) -> assertThat(city.getId()).isNotNull())
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
private static String r2dbcUrl() {
|
||||
|
@ -16,6 +16,8 @@
|
||||
|
||||
package smoketest.rsocket;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
import io.rsocket.metadata.WellKnownMimeType;
|
||||
import org.assertj.core.api.Assertions;
|
||||
import org.junit.jupiter.api.Test;
|
||||
@ -30,8 +32,6 @@ import org.springframework.security.rsocket.metadata.SimpleAuthenticationEncoder
|
||||
import org.springframework.security.rsocket.metadata.UsernamePasswordMetadata;
|
||||
import org.springframework.util.MimeTypeUtils;
|
||||
|
||||
import java.time.Duration;
|
||||
|
||||
@SpringBootTest(properties = "spring.rsocket.server.port=0")
|
||||
class SampleRSocketApplicationTests {
|
||||
|
||||
@ -58,7 +58,8 @@ class SampleRSocketApplicationTests {
|
||||
Mono<Project> result = requester.route("find.project.spring-boot").retrieveMono(Project.class);
|
||||
StepVerifier.create(result)
|
||||
.assertNext((project) -> Assertions.assertThat(project.getName()).isEqualTo("spring-boot"))
|
||||
.expectComplete().verify(Duration.ofSeconds(5));
|
||||
.expectComplete()
|
||||
.verify(Duration.ofSeconds(30));
|
||||
}
|
||||
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user