Reduce StringBuilder creation in TypeExtractor.visitDeclared()

Closes gh-11845
This commit is contained in:
Stephane Nicoll 2018-01-30 16:40:32 +01:00
parent 11f700aa9d
commit f86b44f2ec

View File

@ -187,12 +187,18 @@ class TypeUtils {
return getQualifiedName(enclosingElement) + "$"
+ type.asElement().getSimpleName().toString();
}
StringBuilder name = new StringBuilder();
name.append(getQualifiedName(type.asElement()));
if (!type.getTypeArguments().isEmpty()) {
appendTypeArguments(type, name);
String qualifiedName = getQualifiedName(type.asElement());
if (type.getTypeArguments().isEmpty()) {
return qualifiedName;
}
else {
StringBuilder name = new StringBuilder();
name.append(qualifiedName);
if (!type.getTypeArguments().isEmpty()) {
appendTypeArguments(type, name);
}
return name.toString();
}
return name.toString();
}
private void appendTypeArguments(DeclaredType type, StringBuilder name) {