From dc8b55c0efb10650a0a82747bed322522b625d2f Mon Sep 17 00:00:00 2001 From: skcskitano <150210799+skcskitano@users.noreply.github.com> Date: Mon, 25 Dec 2023 09:55:33 +0900 Subject: [PATCH] Fix connection leak in SqlDialectLookup See gh-38924 --- .../boot/autoconfigure/jooq/SqlDialectLookup.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jooq/SqlDialectLookup.java b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jooq/SqlDialectLookup.java index 4213e39c50b..bfd53a5dacf 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jooq/SqlDialectLookup.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jooq/SqlDialectLookup.java @@ -46,8 +46,7 @@ final class SqlDialectLookup { * @return the most suitable {@link SQLDialect} */ static SQLDialect getDialect(DataSource dataSource) { - try { - Connection connection = (dataSource != null) ? dataSource.getConnection() : null; + try (Connection connection = (dataSource != null) ? dataSource.getConnection() : null) { return JDBCUtils.dialect(connection); } catch (SQLException ex) {