Commit Graph

1478 Commits

Author SHA1 Message Date
Phillip Webb
6a55623910 Polish 2017-12-13 12:21:57 -08:00
Stephane Nicoll
7fb0bd77cd Polish "Handle null Principal in AuditEvent"
Closes gh-11320
2017-12-12 08:45:20 +01:00
nklmish
6b6a01a7e7 Handle null Principal in AuditEvent
See gh-11320
2017-12-12 08:38:46 +01:00
Andy Wilkinson
654fe9a31c Use Checkstyle to police accidental use of unwanted imports
Closes gh-11271
2017-12-06 13:56:17 +00:00
Stephane Nicoll
7b8adfab41 Polish 2017-11-30 18:00:43 +01:00
Spring Buildmaster
df2ae7aa19 Next Development Version 2017-11-28 09:55:46 +00:00
Andy Wilkinson
276a9a0eec Reflect each source's values in env endpoint's response
Previously, the env endpoint would use the entire environment to
get the value of each property in a source. This meant that when
there were multiple sources with the same property, the value from
the source with the highest precedence would be used for every
source that contains the property.

This commit update the endpoint to retrieve the value from the
property source that is being described, rather than resolving it
against all the environment's property sources.

Closes gh-10883
2017-11-23 13:09:48 +00:00
Andy Wilkinson
85dc89e1b4 Make serialization of @ConfigurationProperties beans more defensive
Previously, serialization of a @ConfigurationProperties bean to JSON
would fail if:

- A property on the bean returned the bean (the bean was
  self-referential)
- An exception was thrown when attempting to retrieve a property's
  value.

This commit makes the serialization more defensive by skipping any
property that is affected by either of the problems described above.
Debug logging has been added to aid diagnosis of missing properties.

Closes gh-10846
2017-11-15 19:09:22 +00:00
Johnny Lim
c718880354 Handle null early in Sanitizer.sanitize()
Closes gh-10806
2017-10-29 14:03:55 +01:00
Spring Buildmaster
c0f9f64776 Next Development Version 2017-10-16 12:36:43 +00:00
Andy Wilkinson
43aa7dbaf1 Polish "Provide informative reason when rejecting request with invalid level"
See gh-10588
2017-10-13 10:55:35 +01:00
Eddú Meléndez
9e5a1b32c8 Provide informative reason when rejecting request with invalid level
Previously, bad request with no reason was included in the response.
This commit introduces the reason when invalid log level is sent in the
request.

Fixes gh-10588
2017-10-13 10:54:14 +01:00
Andy Wilkinson
aca30950cf Polish "Align prefix match in BufferCounterService with DefaultCounterService"
See gh-10278
2017-09-20 06:51:22 +01:00
Venil Noronha
dcb81a3da5 Align prefix match in BufferCounterService with DefaultCounterService
Closes gh-10278
2017-09-20 06:34:29 +01:00
Spring Buildmaster
30eb937a83 Next Development Version 2017-09-12 10:54:22 +00:00
Madhura Bhave
86cd7275a1 MVC endpoints bean methods are @ConditionalOnMissingBean
Fixes gh-10105
2017-09-06 15:32:10 -07:00
Paul Vorbach
04ca7f137d Identify and fix incomplete assertions
Several calls to assertThat lacked a following assertion most often due
to wrong use of parenthesis.

See gh-10084
2017-08-29 13:49:28 +02:00
Johnny Lim
ee3de15e37 Add more ConditionalOnClass checks in HealthIndicatorAutoConfiguration
Closes gh-9940
2017-08-09 11:52:18 +01:00
Andy Wilkinson
5a8a86375d Sanitize individual env entry that is matched exactly
Closes gh-9918
See gh-8282
2017-07-31 15:27:55 +01:00
Stephane Nicoll
5c13b8bf50 Separate custom schema configuration for Liquibase test
Unfortunately, creating the schema in code did not offer the right
condition to reproduce the error scenario. This commit restore the
initial intent, but separating the configuration and cleaning the
created context properly.

See gh-9862
2017-07-28 11:59:15 +02:00
Stephane Nicoll
7736cb1dc5 Fix test so that it doesn't leave a datasource hanging around
Closes gh-9862
2017-07-28 11:43:28 +02:00
Stephane Nicoll
7e21178f63 Polish "Use configured schema in Liquibase endpoint"
Closes gh-9862
2017-07-28 10:21:27 +02:00
Craig Andrews
3e13970fe0 Use configured schema in Liquibase endpoint
This commit makes sure that the Liquibase endpoint uses the configured
schema.

See gh-98£62
2017-07-28 10:21:27 +02:00
Spring Buildmaster
17a5bb0be4 Next development version 2017-07-27 08:00:21 +00:00
Spring Buildmaster
41c5c0e7c9 Next development version 2017-07-26 08:30:55 +00:00
Johnny Lim
d18e452fcd Use currentHealth consistently in getHealth()
Closes gh-9832
2017-07-22 08:21:43 +01:00
Andy Wilkinson
bbc34a676c Polish "Handle possible regexes defensively in NamePatternFilter"
Closes gh-9730
2017-07-21 17:24:01 +01:00
dbego
c29d1c756a Handle possible regexes defensively in NamePatternFilter
Previously, if a name contained part of a regex but wasn't actually
a regex, a PatternSyntaxException would be thrown and the request
would fail.

This commit updates NamePatternFilter to catch PatternSyntaxException
and treat the regex-like input as a name insteead.

See gh-9730
2017-07-21 17:21:49 +01:00
Phillip Webb
68910f2b8f Polish 2017-07-19 10:21:06 -07:00
Phillip Webb
cd23de6ed5 Add more HealthIndicatorAutoConfiguration ordering
Update HealthIndicatorAutoConfiguration to ensure that it is configured
after ActiveMQAutoConfiguration.

Fixes gh-9793
2017-07-19 10:19:42 -07:00
孙健
1745a5ee6f Fix metric check in case of duplicate metric
Closes gh-9497
2017-07-19 15:43:28 +02:00
Madhura Bhave
0f8a819af9 Enable cors in default management security config
Fixes gh-9548
2017-07-17 10:49:48 -07:00
Phillip Webb
aa57ca7e18 Polish 2017-07-06 16:53:04 -07:00
Stephane Nicoll
88d16ddf6b Add missing class check
Closes gh-9602
2017-06-26 13:36:34 +02:00
Andy Wilkinson
7a04708c41 Make sure the HealthMvcEndpoint is thread-safe
Previously, HealthMvcEndpoint stored the cached Health and its last
access time in two separate fields. Neither field was volatile and
no synchronization was used. This meant that there were potential
visibility problems. In a possible worst case scenario one field may
see the updated access time but an old health so it would incorrectly
believe that the old health was up-to-date and return it.

This commit reworks the endpoint to store the cached health and the
time at which it was created in a single, volatile field. This ensures
that the cached health and its creation time will be visible across
threads. Note that a race between threads when the cache is stale is
still possible. This race may result in multiple calls to the
delegate but these should be harmless.

Closes gh-9454
2017-06-21 14:19:10 -07:00
Stephane Nicoll
3f70638f1c Polish "Use getUsableSpace() in DiskSpaceHealthIndicator"
Closes gh-9544
2017-06-20 14:44:11 +02:00
Huang YunKun
158416fdd0 Use getUsableSpace() in DiskSpaceHealthIndicator
See gh-9544
2017-06-20 14:43:38 +02:00
Spring Buildmaster
05d4d0281c Next Development Version 2017-06-08 12:47:16 +00:00
Andy Wilkinson
9579e95868 Handle explicit disablement of management SSL correctly
Closes gh-9423
2017-06-07 13:57:59 +01:00
Phillip Webb
b9fd99e268 Polish 2017-06-02 13:47:28 -07:00
Stephane Nicoll
9fc90a809f Add missing @Test annotations 2017-06-01 13:37:05 +02:00
Stephane Nicoll
d4a0fe5ff9 Polish "Fix configuration properties output for actuator"
Closes gh-9052
2017-05-23 10:48:45 +02:00
Wesley Stratton
7d6293f79d Fix configuration properties output for actuator
See gh-9052
2017-05-23 10:48:45 +02:00
Stephane Nicoll
4cc515054e Merge branch '1.4.x' into 1.5.x 2017-05-22 11:06:40 +02:00
Stephane Nicoll
a59000354c Support for TransactionAwareCacheDecorator
This commit makes sure to unwrap any transaction aware cache before
collecting metrics for them.

Closes gh-8984
2017-05-22 11:05:39 +02:00
Gytis Trikleris
00823d41a9 Log a warning if a health indicator throws an exception
Closes gh-9110
2017-05-15 19:53:55 +01:00
Phillip Webb
931ce15d7f Update copyright header dates 2017-05-09 21:43:52 -07:00
Phillip Webb
4a7dcc8786 Formatting 2017-05-09 21:43:24 -07:00
Madhura Bhave
3d836f7730 Fix test pollution 2017-05-04 12:20:21 -07:00
Madhura Bhave
189e07e9f3 Support values other than String in /env
Fixes gh-9079
2017-05-04 11:35:15 -07:00