spring-boot/spring-boot-project
Andy Wilkinson 81dc0cc3cf Eliminate race condition in Tomcat's graceful shutdown
There was a race condition between the thread that's waiting for
Tomcat to become inactive or the graceful shutdown to be aborted
and the thread that aborts the shutdown and stops Tomcat when the
grace period has elapsed. This race can lead to Tomcat appearing
to have become inactive before the abort of the shutdown is
noticed. When this happens, the result of the shutdown is reported
as IDLE when it should have been REQUESTS_ACTIVE. The consequences
of this are mostly benign although it does affect the log messages
that are emitted. It is also causing some of our graceful shutdown
tests to be flaky.

This commit eliminates the race condition by considering the
state of the aborted flag before logging and returning the result
of the shutdown.

Closes gh-39942
2024-03-15 15:30:41 +00:00
..
spring-boot Eliminate race condition in Tomcat's graceful shutdown 2024-03-15 15:30:41 +00:00
spring-boot-actuator Harmonize style of igored exceptions across the codebase 2024-02-12 10:14:20 +01:00
spring-boot-actuator-autoconfigure Update copyright year of changed files 2024-02-21 13:58:53 -08:00
spring-boot-autoconfigure Stop throwing BindingException in tests 2024-02-27 14:12:19 -06:00
spring-boot-dependencies Upgrade to Neo4j Java Driver 5.18.0 2024-03-13 19:14:34 +00:00
spring-boot-devtools Fix Checkstyle upgrade 2024-01-10 15:37:38 +00:00
spring-boot-docker-compose Update copyright year of changed files 2024-02-21 13:58:53 -08:00
spring-boot-docs Fix Typo in Spring Boot Docs Section 10.1 Custom HTTP Exchange Recording 2024-02-28 12:58:53 +01:00
spring-boot-parent Revert "Stop managing version of commons-compress where it isn't needed" 2024-02-06 12:36:26 +00:00
spring-boot-starters Remove OCI entry as it is no longer maintained 2024-01-17 10:42:27 +00:00
spring-boot-test Harmonize style of igored exceptions across the codebase 2024-02-12 10:14:20 +01:00
spring-boot-test-autoconfigure Harmonize style of igored exceptions across the codebase 2024-02-12 10:14:20 +01:00
spring-boot-testcontainers Harmonize style of igored exceptions across the codebase 2024-02-12 10:14:20 +01:00
spring-boot-tools Improve BuildpackReference's handling of URL-like strings on Windows 2024-02-28 17:15:02 +00:00