mirror of
https://github.com/spring-projects/spring-boot.git
synced 2024-08-29 03:06:45 +08:00
5765cfe010
Previously, when RunProcess handled a SIGINT it would immediately attempt to destroy the process that it had run. This created a race condition between the SIGINT being handled by the child process and RunProcess destroying the child. The exact behavior of destroy is implementation dependent and it may result in forcible termination of the process where shutdown hooks are not called. This is what happens on Windows. The exit code in such a case is 1 which prevents anything from waiting for the process to complete from detecting that it ended as a result of a SIGINT, leaving it with no choice but to report an error. This is what happens with mvn spring-boot:run with a forked process on Windows and results in the build failing. This commit updates RunProcess to allow the child process to handle the SIGINT itself, waiting for up to five seconds for that to happen before the process is then destroyed. Given this time, the child process exits with 130 which RunMojo already handles correctly as indicating that the process died due to SIGINT and the build completes with success as a result. Fixes gh-18936 |
||
|---|---|---|
| .. | ||
| spring-boot-antlib | ||
| spring-boot-autoconfigure-processor | ||
| spring-boot-configuration-metadata | ||
| spring-boot-configuration-processor | ||
| spring-boot-gradle-plugin | ||
| spring-boot-loader | ||
| spring-boot-loader-tools | ||
| spring-boot-maven-plugin | ||
| spring-boot-test-support | ||
| pom.xml | ||